Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor swr part2 #1206

Merged
merged 7 commits into from
Sep 8, 2024
Merged

Refactor swr part2 #1206

merged 7 commits into from
Sep 8, 2024

Conversation

stijnvanhulle
Copy link
Collaborator

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 90ad72b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@stijnvanhulle stijnvanhulle force-pushed the chore/refactor-swr-part2 branch 2 times, most recently from c47bb13 to 5420e0e Compare September 8, 2024 16:27
@stijnvanhulle stijnvanhulle force-pushed the chore/refactor-swr-part2 branch from 5420e0e to 90ad72b Compare September 8, 2024 16:38
@codecov Codecov
Copy link

codecov bot commented Sep 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.28483% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.60%. Comparing base (15ebe18) to head (90ad72b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/plugin-swr/src/components/Mutation.tsx 91.83% 4 Missing ⚠️
packages/plugin-swr/src/components/Query.tsx 92.30% 4 Missing ⚠️
...ackages/plugin-swr/src/components/QueryOptions.tsx 92.59% 2 Missing ⚠️
packages/core/src/build.ts 0.00% 1 Missing ⚠️
packages/plugin-swr/src/components/SchemaType.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
+ Coverage   76.81%   77.60%   +0.78%     
==========================================
  Files         138      138              
  Lines        9788     9692      -96     
  Branches     1695     1692       -3     
==========================================
+ Hits         7519     7521       +2     
+ Misses       2257     2160      -97     
+ Partials       12       11       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stijnvanhulle stijnvanhulle merged commit a7ec6c4 into main Sep 8, 2024
10 checks passed
@stijnvanhulle stijnvanhulle deleted the chore/refactor-swr-part2 branch September 8, 2024 16:47
@kubb-labs
Copy link

kubb-labs bot commented Sep 9, 2024 •
edited
Loading

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2024-09-09 17:47:29 CET

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stijnvanhulle